jinghua-qa commented on PR #20519: URL: https://github.com/apache/superset/pull/20519#issuecomment-1171404213
> > @kgabryje @jinghua-qa I leave a few common use cases so that we can test this PR > > # Test case Result > > 1 Open an existing chart success > > 2 Open an existing virtual/physical dataset failure > > 3 Edit a Chart when clicking `edit chart` from Dashboard success > > 4 Create a dataset from SQLLab failure > > 5 Open an existing chart, and then switch to different datasets success > > 6 Open an existing chart and the current user is admin; the user should permit editing the current dataset failure > > 7 Manually construct an exception response, the explore page should show default interface success > > Wondering if we should add these cases to Cypress as these seems all scenarios that should have failed in CI. > > The code LGTM. I am going to pull this branch as I need it as a base to test another PR and I will report all eventual issues that I find, if any. > > P.S. Sorry didn't mean to close the PR :) Good idea!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
