lyndsiWilliams opened a new pull request, #20570: URL: https://github.com/apache/superset/pull/20570
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This changes the current save query button into a split save button if the database has "Allow this database to be explored" enabled. When the user clicks the caret section of the button, they can now save the query as a dataset. `Bonus`: In order to create this button, I conveniently needed to fix the styling on the "Run" query split button. The split line now goes all the way through the button and the caret is centered. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> #### BEFORE:   #### AFTER:    ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> - From SqlLab, open a query for a database that has "Allow this database to be explored" enabled. - Observe the new split save button - Click the "Save" section of the button to see the save query modal - Click the caret `v` section of the button, then click "Save dataset" to see the save dataset modal - Both of these modals should be fully functional - From SqlLab, open a query for a database that does NOT have "Allow this database to be explored" enabled. - Observe that the save button is a normal button, not split - Clicking this button should show the save query modal ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
