diegomedina248 opened a new pull request, #20591:
URL: https://github.com/apache/superset/pull/20591

   ### SUMMARY
   
   When `GENERIC_CHART_AXES` is enabled, stacking on bar chart v2 is not 
working correctly in all cases.
   The reason is that bar stacking is supported by echarts only for categorical 
types.
   Source: https://github.com/apache/echarts/issues/15102
   
   This PR hides that feature if the axis is not categorical.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Before:
   
   
https://user-images.githubusercontent.com/17252075/176978590-653b4411-ed1a-4e1f-a0a9-d138b6091b29.mov
   
   After:
   
   
https://user-images.githubusercontent.com/17252075/176978651-8ff74bd7-45f6-49d8-9641-11d635317692.mov
   
   ### TESTING INSTRUCTIONS
   1. Enable `GENERIC_CHART_AXES`.
   2. Create Bar v2 charts with different types in the x-types.
   
   Ensure the stack option is only available for categorical types, and that it 
works as expected.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to