kgabryje commented on code in PR #20572:
URL: https://github.com/apache/superset/pull/20572#discussion_r913260587
##########
superset/models/slice.py:
##########
@@ -286,14 +286,14 @@ def get_query_context(self) -> Optional[QueryContext]:
def get_explore_url(
self,
- base_url: str = "/superset/explore",
+ base_url: str = "/explore",
overrides: Optional[Dict[str, Any]] = None,
) -> str:
overrides = overrides or {}
form_data = {"slice_id": self.id}
form_data.update(overrides)
Review Comment:
Not sure if `overrides` will be recognized by the new explore endpoint,
since it doesn't handle `form_data` param
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
