rusackas commented on code in PR #20566:
URL: https://github.com/apache/superset/pull/20566#discussion_r914404318
##########
superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx:
##########
@@ -163,17 +164,34 @@ const config: ControlPanelConfig = {
name: 'normalize_across',
config: {
type: 'SelectControl',
- label: t('Normalize Across'),
+ label: t('Color based on'),
choices: [
['heatmap', 'heatmap'],
['x', 'x'],
['y', 'y'],
],
default: 'heatmap',
- description: t(
- 'Color will be rendered based on a ratio ' +
- 'of the cell against the sum of across this ' +
- 'criteria',
+ description: (
+ <>
+ <div>
+ {t(
+ 'Color will be rendered based on a ratio of the cell
against the sum of across this criteria: ',
+ )}
+ </div>
+ <ul>
+ <li>
+ {t('x: percentage of the highest value in that column')}
Review Comment:
```suggestion
{t('x: values are normalized within each column')}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
