[GitHub] [superset] Antonio-RiveroMartnez opened a new pull request, #20627: fix(chart): Time Series set showMaxLabel as null for time xAxis

[GitBox]

Antonio-RiveroMartnez opened a new pull request, #20627:
URL: https://github.com/apache/superset/pull/20627

   ### SUMMARY
   - Apache Echarts has `showMaxLabel` option set to `false` by default for 
time axis 
(https://github.com/apache/echarts/blob/master/src/coord/axisDefault.ts#L178), 
so we need to override it for our time series charts in order to not be fixed 
with hidden and instead let the library determine whether to show the label of 
the max tick
   - Add AxisType enum so we stop comparing agains raw strings when checking 
xAxis type
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   BEFORE:
   
![error](https://user-images.githubusercontent.com/38889534/177609650-947e9ff0-2005-426a-9aa8-558623ef7404.gif)
   
   AFTER:
   
![test](https://user-images.githubusercontent.com/38889534/177610754-3e12270a-b91a-4a58-b6ef-57870937e5a3.gif)
   
   
   ### TESTING INSTRUCTIONS
   1. Go to a time series line chart with monthly data from the example datasets
   2. Chose month time grain
   3. Expected results: last month should show on X axis
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org