eric-briscoe commented on code in PR #20338:
URL: https://github.com/apache/superset/pull/20338#discussion_r915322204
##########
superset-frontend/packages/superset-ui-core/test/chart/fixtures/formData.ts:
##########
@@ -19,13 +19,14 @@
/* eslint sort-keys: 'off' */
/** The form data defined here is based on default visualizations packaged
with Apache Superset */
+import { TimeGranularity } from '../../../src/time-format/types';
Review Comment:
I agree with @eschutho, we want to avoid core importing from anywhere else
to avoid circular scenario. We could just make it a string, or consider moving
the time-format constants to core like we have with other types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
