michael-s-molina commented on code in PR #20645:
URL: https://github.com/apache/superset/pull/20645#discussion_r916769384
##########
superset-frontend/packages/superset-ui-chart-controls/src/types.ts:
##########
@@ -79,6 +81,7 @@ export interface Dataset {
description: string | null;
uid?: string;
owners?: Owner[];
+ table_name?: string;
Review Comment:
I'm trying to replace `Datasource` in `src/dashboard/types` with `Dataset`.
```
export type Datasource = Dataset & {
uid: string;
column_types: GenericDataType[];
table_name: string;
};
```
> I'm curious, why do we need to append table_name to a column?
Dataset does not represent a column and can contain an origin table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
