eschutho commented on code in PR #20281:
URL: https://github.com/apache/superset/pull/20281#discussion_r918193398
##########
superset-frontend/src/SqlLab/components/ResultSet/index.tsx:
##########
@@ -220,6 +224,15 @@ export default class ResultSet extends React.PureComponent<
const { showSaveDatasetModal } = this.state;
const { query } = this.props;
+ const dataset: ISaveableDataset = {
+ columns: query.columns as ISimpleColumn[],
+ name: query?.tab || 'Untitled',
+ dbId: 1,
+ sql: query.sql,
+ templateParams: query.templateParams,
+ schema: query.schema,
Review Comment:
if this is a query and not a dataset, can we call it something more generic
like a datasource? Dataset is a different model altogether, so it's a little
confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
