ktmud commented on code in PR #20632:
URL: https://github.com/apache/superset/pull/20632#discussion_r919409668
##########
superset/key_value/utils.py:
##########
@@ -63,3 +64,9 @@ def get_uuid_namespace(seed: str) -> UUID:
md5_obj = md5()
md5_obj.update(seed.encode("utf-8"))
return UUID(md5_obj.hexdigest())
+
+
+def get_deterministic_uuid(namespace: str, payload: Any) -> UUID:
+ """Get a deterministic UUID (uuid3) from a salt and a payload."""
+ payload_str = json_dumps_w_dates(payload, sort_keys=True)
Review Comment:
I still don't think it's a good idea to store language-specific serialized
data in databases---even though Superset is predominantly a Python app. I can
see the case when we need to store other binary data, e.g., image files, cache
for zipped exports, encrypted data, etc, so maybe the `value` column indeed
needs to be binary. A customizable serializer sounds like a good idea. Let's
revisit when offline analysis becomes a real need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
