dpgaspar commented on code in PR #20700:
URL: https://github.com/apache/superset/pull/20700#discussion_r920239735


##########
RELEASING/Dockerfile.from_local_tarball:
##########
@@ -30,7 +30,7 @@ RUN apt-get install -y apt-transport-https apt-utils
 # Install superset dependencies
 # 
https://superset.apache.org/docs/installation/installing-superset-from-scratch
 RUN apt-get install -y build-essential libssl-dev \
-    libffi-dev python3-dev libsasl2-dev libldap2-dev libxi-dev
+    libffi-dev python3-dev libsasl2-dev libldap2-dev libxi-dev chromium

Review Comment:
   could be more defensive and add an extra line with:
   ```
   RUN if [ $(arch) == "aarch64" ]; then apt-get install chromium; fi
   ```
   
   But would add another layer to the container and it should be fine on non M1 
also



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to