codyml opened a new pull request, #20704: URL: https://github.com/apache/superset/pull/20704
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> The combination of #20498 and #20645 caused a regression in Explore logic such that when a chart is saved as a new chart, the chart wouldn't render once the modal was closed without clicking the "Update Chart" button. This broke a Cypress test, `explore/link.test.ts` that's currently failing on master, but which wasn't picked up by CI before merge because CI on #20645 was run before #20498 had been merged and the two PRs didn't have any conflicts that would prompt GH to require a rebase. This PR reverts a little bit of #20645, making the `HYDRATE_EXPLORE` Redux action once again update the `datasources` store key in the same step instead of in a different step. I don't really understand why this change fixes the issue, but it seems like the Explore components only refresh as expected if `datasources` is updated as part of the `HYDRATE_EXPLORE` action. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> Before: https://user-images.githubusercontent.com/13007381/178867373-61856316-c0b5-434f-a62b-a91801da183e.mov After: https://user-images.githubusercontent.com/13007381/178867380-54804f8b-4f64-4d69-9f3a-a33e07133078.mov ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> - Check that saving a chart as a new chart causes the chart to render. - Check that Cypress tests are now passing. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
