codyml commented on code in PR #20683:
URL: https://github.com/apache/superset/pull/20683#discussion_r922566596
##########
superset/datasets/commands/samples.py:
##########
@@ -78,3 +116,24 @@ def validate(self) -> None:
security_manager.raise_for_ownership(self._model)
except SupersetSecurityException as ex:
raise DatasetForbiddenError() from ex
+
+ @staticmethod
+ def get_limit_clause(
+ page: Optional[int], per_page: Optional[int]
+ ) -> Dict[str, int]:
+ samples_row_limit = app.config.get("SAMPLES_ROW_LIMIT", 1000)
+ limit = samples_row_limit
+ offset = 0
+
+ if isinstance(page, int) and isinstance(per_page, int):
+ limit = int(per_page)
+ if limit < 0 or limit > samples_row_limit:
+ # reset limit value if input is invalid
+ limit = samples_row_limit
+
+ offset = (int(page) - 1) * limit
Review Comment:
I think the frontend defaults to 0-indexed page numbers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
