john-bodley opened a new pull request, #20757: URL: https://github.com/apache/superset/pull/20757
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY The `PrestoEngineSpec._show_columns` method stated it returned a `List[RowProxy]` type however it actually returned a `ResultProxy`, i.e., per the SQLAlchemy [documentation](https://docs.sqlalchemy.org/en/13/core/connections.html), > The [RowProxy](https://docs.sqlalchemy.org/en/13/core/connections.html?highlight=rowproxy#sqlalchemy.engine.RowProxy) object is retrieved from a database result, from the [ResultProxy](https://docs.sqlalchemy.org/en/13/core/connections.html?highlight=rowproxy#sqlalchemy.engine.ResultProxy) object using methods like [ResultProxy.fetchall()](https://docs.sqlalchemy.org/en/13/core/connections.html?highlight=rowproxy#sqlalchemy.engine.ResultProxy.fetchall). From a coding perspective this wasn't problematic as the output is later processed via, ```python for column in PrestoEngineSpec._show_columns(...): .... ``` and though the `ResultProxy` supports iteration—per the `__iter__` method in the DB API, it does not support pickling (and thus caching) whereas the `RowProxy` does (it's acts somewhat akin to a Python `tuple`). This was resulting in an issue at Airbnb where we actually override and cache the `PrestoEngineSpec._show_columns` output. The fix is merely to augment the method to return a `List[RowProxy]` as promised rather than a `ResultProxy`. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS CI. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
