justinpark opened a new pull request, #20778:
URL: https://github.com/apache/superset/pull/20778

   ### SUMMARY
   
   The current native filterbar section is fixed size.
   Since the filter is not wide enough for moderately wide data to be seen, 
some filter value with the long overlapped prefix string such like the 
following case truncated with the repeated strings.
   
   <img width="262" alt="Screen Shot 2022-07-14 at 1 46 21 PM" 
src="https://user-images.githubusercontent.com/1392866/179846536-fb2484bf-c8c3-4594-ab7b-ce0adbcf2732.png";>
   
   There is an HTML tooltip that appear on mouseover but it's slow and bad user 
experience.
   The dropdown needs to be widened over the sidebar but the dropdown also 
truncated under the sidebar to fix the  
https://github.com/apache/superset/pull/19399 
   
   <img width="348" alt="Screen Shot 2022-07-19 at 2 14 41 PM" 
src="https://user-images.githubusercontent.com/1392866/179849717-dff01a09-f75e-4bf1-a959-4db3295dca4d.png";>
   
   Therefore, this commit makes the sidebar resizable to be widened itself.
   This commit adds the Resizable panel for native filterbar to adjust the 
width wider to help this inconvenient case.
   It also stores the adjusted width for individual dashboard in localStorage 
to memorize the state.
   
   Addition to the feature, this commit also migrates DashboardBuilder test 
code to testing-library, jest and typescript to enable emotion test helpers.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Before:
   
   
https://user-images.githubusercontent.com/1392866/179843448-425ad37d-9a6d-409e-abdc-b78cfa2f4412.mov
   
   After:
   
   
https://user-images.githubusercontent.com/1392866/179843423-4effc912-42d3-4811-8d2a-6aeacd7b0d79.mov
   
   ### TESTING IN
   
   STRUCTIONS
   
   - Go to dashboard and then open the native filter menu
   - hover on the right edge of the menu
   - drag to adjust the width
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue:
   - [x] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [x] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to