kgabryje commented on code in PR #20743:
URL: https://github.com/apache/superset/pull/20743#discussion_r925441656
##########
superset-frontend/src/dashboard/components/SliceHeader/index.tsx:
##########
@@ -97,6 +98,7 @@ const SliceHeader: FC<SliceHeaderProps> = ({
}) => {
const dispatch = useDispatch();
const uiConfig = useUiConfig();
+ const dashboardTabId = useContext(DashboardTabIdContext);
Review Comment:
We only need to pass dashboardTabId deep into the component tree, with no
intention of ever modifying it or interacting with other redux state variables.
I think for such use cases Context is optimal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
