zhaoyongjie commented on PR #20683: URL: https://github.com/apache/superset/pull/20683#issuecomment-1192044714
> @zhaoyongjie Thank you so much for cleaning the duplicated `samples` endpoint in `datasets/api` and `explore/api`. May I suggest creating the endpoint under `api/v1/dataset/samples` instead of `superset/views`? This would help with the new API migration. @codyml @michael-s-molina this is an interesting question, because now it is not dataset samples but different types of datasouce samples, so it should not be put under dataset. v1 API still has a lot of work to do, for example: 1. a lot of error handles(try...except statement) v1 are not well solved 2. `/api/v1/chart/data` has lots of duplicated samples code So the view and v1 api will coexist for a long time. I will address these issues in the new PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
