dungdm93 commented on PR #20152: URL: https://github.com/apache/superset/pull/20152#issuecomment-1192657809
@john-bodley, @zhaoyongjie guys. Trino engine using [`sqlalchemy-trino`](https://github.com/dungdm93/sqlalchemy-trino/) and now official [`trino-python-client`](https://github.com/trinodb/trino-python-client/) driver. Unlike Presto and Hive which are based on PyHive. I'm not sure make Trino inherit from `PrestoEngineSpec` is good or should we leave it going its own path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
