[GitHub] [superset] kgabryje opened a new pull request, #20847: fix: Fix chart title truncating when Chrome is zoomed out

[GitBox]

kgabryje opened a new pull request, #20847:
URL: https://github.com/apache/superset/pull/20847

   
   ### SUMMARY
   When user zoomed out the browser (could repro only in Chrome, Safari and 
Firefox worked fine), titles of some charts would truncate. That's because for 
some reason (probably browser bug) the input container decreased it's width by 
0.01px. This PR adds 1px to the input container as a failsafe.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   <img width="492" alt="image" 
src="https://user-images.githubusercontent.com/15073128/180797200-591ab270-8505-4ecb-ad32-3a155bc9f031.png";>
   
   After:
   <img width="559" alt="image" 
src="https://user-images.githubusercontent.com/15073128/180796474-3b10989a-0d64-4051-be88-adcad5d6d397.png";>
   
   
   ### TESTING INSTRUCTIONS
   1. Open Explore, zoom out Chrome (with cmd -)
   2. Verify that title is not truncated (unless it should be because there's 
actually too little space of course)
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org