zhaoyongjie commented on code in PR #20842: URL: https://github.com/apache/superset/pull/20842#discussion_r929012269
########## superset-frontend/packages/superset-ui-core/test/utils/lruCache.test.ts: ########## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import { lruCache } from '@superset-ui/core'; + +describe('simple LRUCache', () => { + test('initial LRU', () => { + expect(lruCache().capacity).toBe(100); + expect(lruCache(10).capacity).toBe(10); + expect(lruCache(10).size).toBe(0); + expect(() => lruCache(0)).toThrow(Error); + }); + + test('LRU', () => { Review Comment: @michael-s-molina Sorry, my point was that each call to `get` and `set` has an effect on the entire LRU, for example, the `correctly evicts LRU value` and the `correctly updates LRU value` should operate on a same LRU instance rather than separately. For this argument, we should probably get someone else to take a look at it as well, and I'd be happy to revise it, thank you very much for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
