lyndsiWilliams commented on code in PR #20852:
URL: https://github.com/apache/superset/pull/20852#discussion_r929239346
##########
superset-frontend/src/SqlLab/components/ResultSet/index.tsx:
##########
@@ -29,19 +29,14 @@ import {
SaveDatasetModal,
} from 'src/SqlLab/components/SaveDatasetModal';
import { UserWithPermissionsAndRoles } from 'src/types/bootstrapTypes';
-import { EXPLORE_CHART_DEFAULT } from 'src/SqlLab/types';
Review Comment:
Yeah there seems to be some weird rebase stuff on this PR, thanks for
catching all these! Re-added in [`this
commit`](https://github.com/apache/superset/pull/20852/commits/61bdc42398bc3e8f458d1ba27536a4322b8e5097).
##########
superset-frontend/src/SqlLab/components/ResultSet/index.tsx:
##########
@@ -218,26 +213,6 @@ export default class ResultSet extends React.PureComponent<
}
}
- createExploreResultsOnClick = async () => {
Review Comment:
Re-added in [`this
commit`](https://github.com/apache/superset/pull/20852/commits/61bdc42398bc3e8f458d1ba27536a4322b8e5097).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
