eschutho opened a new pull request, #20879:
URL: https://github.com/apache/superset/pull/20879

   ### SUMMARY
   The `having_druid` key still exists in some query table extras json blobs in 
the database. We removed the key from the schema in the native druid cleanup 
work https://github.com/apache/superset/pull/20338 but need to run a migration 
in order to remove the key permanently from query objects. This PR is a 
temporary fix to add the property back into the schema for an easier cherry 
prior to the db migration. We need to remove this property again and run the 
migration together next. 
   
   The error that we're seeing is on some reports that still have the old 
key`{"message":"Request is incorrect: {'queries': {0: {'extras': 
{'having_druid': ['Unknown field.']}}}}"}`
   
   ### TESTING INSTRUCTIONS
   I added `having_druid` to an existing test and validated that it failed and 
then fixed the code and validated that it passed. 
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to