zhaoyongjie commented on code in PR #20882:
URL: https://github.com/apache/superset/pull/20882#discussion_r931274711


##########
tests/integration_tests/viz_tests.py:
##########
@@ -739,19 +739,13 @@ def test_get_data_empty_null_keys(self):
                     "group": "All",
                 }
             ],
-            "NULL": [
-                {
-                    "values": [
-                        {"x": 100, "y": 10},
-                        {"x": 200, "y": 20},
-                        {"x": 300, "y": 30},
-                    ],
-                    "group": "All",
-                }
-            ],
         }
         self.assertEqual(data, expected)
 
+        form_data = {"groupby": [], "metrics": [None]}

Review Comment:
   the more unit test at 
[here](https://github.com/apache/superset/blob/5572f3f42442e617d55759e7203d590102adc58b/tests/unit_tests/core_tests.py#L89).
 I added some invalid metric case as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to