michael-s-molina commented on code in PR #20890: URL: https://github.com/apache/superset/pull/20890#discussion_r932539522
########## superset-frontend/src/components/GenericLink/GenericLink.tsx: ########## @@ -0,0 +1,51 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import React from 'react'; +import { Link, LinkProps } from 'react-router-dom'; + +export const GenericLink = ({ + to, + component, + replace, + innerRef, + children, + ...rest +}: // css prop type check was failing, override with any +LinkProps & { css?: any }) => { + if (typeof to === 'string' && /^https?:\/\//.test(to)) { Review Comment: > This PR, even with more foolproof external url detection, wouldn't change that behaviour - we'd still get an <a> element linking to http://localhost:9000/tablemodelview/list/www.google.com. I was thinking that upon detecting www.google.com as an external link without a protocol, then the component would add the protocol automatically, setting the `<a>` tag to `http://www.google.com`. Of course, we can implement this outside of the component but in that case we would need to always call the helper function before using the component. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
