[GitHub] [superset] justinpark opened a new pull request, #20909: fix(plugin-chart-pivot-table): Invalid Formats Date Fields

[GitBox]

justinpark opened a new pull request, #20909:
URL: https://github.com/apache/superset/pull/20909

   ### SUMMARY
   When a custom date field value converted in a string format, some 
aggregators truncated to the first four digits.
   This is caused by the parseFloat function which converts to first matched 
number rather than NaN(Not-A-Number) value.
   This commit replaces the parseFloat by Number wrapper to handle this case 
correctly.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   
   <img width="571" alt="Screen_Shot_2022-07-28_at_3_28_39_PM" 
src="https://user-images.githubusercontent.com/1392866/181651783-323cf0ed-1cd8-4492-9096-b49e0f259065.png";>
   
   After:
   
   <img width="620" alt="Screen_Shot_2022-07-28_at_3_32_41_PM" 
src="https://user-images.githubusercontent.com/1392866/181651918-5ae5db95-945f-4216-90bd-5cc50cb8eb5b.png";>
   
   
   ### TESTING INSTRUCTIONS
   storybook
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org