codyml commented on code in PR #20902: URL: https://github.com/apache/superset/pull/20902#discussion_r933347007
########## superset-frontend/src/components/RouteLeaveGuard/RouteLeaveGuard.tsx: ########## @@ -0,0 +1,58 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import React, { useEffect, useRef } from 'react'; +import { Prompt } from 'react-router-dom'; +// eslint-disable-next-line import/no-extraneous-dependencies +import { PromptProps } from 'react-router'; + +const handleUnloadEvent = (e: BeforeUnloadEvent) => { Review Comment: If someone tries to reuse this component to guard against route changes at two places in the same tree, I think there might be unexpected behavior because all `addEventListener`/`removeEventListener` calls from different instances of the component will reference the same function. How about moving it inside the component body so it's re-defined for each instantiation? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
