eschutho commented on code in PR #20317:
URL: https://github.com/apache/superset/pull/20317#discussion_r934866691
##########
superset-frontend/src/explore/components/DatasourcePanel/index.tsx:
##########
@@ -307,11 +307,7 @@ export default function DataSourcePanel({
return true;
};
- const isValidDatasourceType =
- datasource.type === DatasourceType.Dataset ||
- datasource.type === DatasourceType.SlTable ||
- datasource.type === DatasourceType.SavedQuery ||
- datasource.type === DatasourceType.Query;
+ const dataSourceIsQuery = datasource?.type === DatasourceType.Query;
Review Comment:
can we duck type this instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
