yousoph commented on PR #20773: URL: https://github.com/apache/superset/pull/20773#issuecomment-1203066934
* The button text on the Create Dataset and Query Data in SQL Lab doesn't look centered - there's too much space on the right side of the text - can you please double check if you're using the secondary button component? The spacing should be correct on the component * Mocks say "begin visualizing" rather than "start visualizing" on the subheader text * Typo - "to to query your data" with an extra "to" (Button color looks ok) I noticed that the X button and the close button on the Dataset creation modal don't work when I am linked to it from the database connection screen, but they work normally when you open the modal from the CRUD view:  When clicking either of the buttons from the database connection success screen, the header/subheader disappeared and buttons jumped to the top of the modal and a loading state showed up on the modal. The modal shouldn't be moving when the screen is refreshing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
