kgabryje opened a new pull request, #20962: URL: https://github.com/apache/superset/pull/20962
### SUMMARY Sometimes when user entered Explore from Dashboard, Explore was scrolled down and user was stuck in that position. That's because Explore is sometimes mounted with initial scroll set to some value above 0. We are stuck in this position, because of `overflow: hidden` on body. It’s related to how react-router mounts components on navigation, but I haven’t been able to find an answer why this bug is so non-deterministic. We fix it by programmatically scrolling to top when SPA route pathname changes. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF The bug shown in the video shows up only from time to time. After this fix, Explore should always open normally. https://user-images.githubusercontent.com/15073128/182681101-02d03f7e-6fd3-4f7f-b7f6-270d16410580.mov ### TESTING INSTRUCTIONS 1. Open a dashboard 2. Scroll down and open some chart in Explore. 3. Go back to dashboard and repeat step 2. 4. Repeat step 3 multiple times. Bug occurs very randomly. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
