eschutho commented on code in PR #20965:
URL: https://github.com/apache/superset/pull/20965#discussion_r938146695
##########
superset/models/helpers.py:
##########
@@ -1331,7 +1334,8 @@ def get_sqla_query( # pylint:
disable=too-many-arguments,too-many-locals,too-ma
columns_by_name: Dict[str, "TableColumn"] = {
col.get("column_name"): col
- for col in self.columns # col.column_name: col for col in
self.columns
+ # col.column_name: col for col in self.columns
+ for col in self.columns
Review Comment:
It looks like it's the end of a dictionary comprehension, not a for loop, so
no colon needed. The comment change btw was just part of my automated linting
on line length. I'm not actually sure what the comment means, too. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
