ktmud commented on code in PR #20729:
URL: https://github.com/apache/superset/pull/20729#discussion_r939490686
##########
superset/db_engine_specs/trino.py:
##########
@@ -45,6 +46,15 @@ class TrinoEngineSpec(PrestoEngineSpec):
engine_aliases = {"trinonative"} # Required for backwards compatibility.
engine_name = "Trino"
+ @classmethod
+ def get_dbapi_exception_mapping(cls) -> Dict[Type[Exception],
Type[Exception]]:
Review Comment:
Why is this a function instead of attribute? Do we expect the exceptions to
map differently at runtime?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
