ktmud commented on code in PR #20974:
URL: https://github.com/apache/superset/pull/20974#discussion_r940477346
##########
superset/dao/base.py:
##########
@@ -50,14 +50,17 @@ class BaseDAO:
@classmethod
def find_by_id(
- cls, model_id: Union[str, int], session: Session = None
+ cls,
+ model_id: Union[str, int],
+ session: Session = None,
+ no_filter: bool = False,
Review Comment:
nit nit: can we maybe call this `skip_base_filter` to make it even more
explicit? I was confused for a while why `get_by_id` would need still need a
filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
