[GitHub] [superset] Antonio-RiveroMartnez opened a new pull request, #21015: fix(charts): Hide Values greater than Max Y Axis Bound on Mixed Time Series with Bar series

Mon, 08 Aug 2022 12:32:55 -0700 


Antonio-RiveroMartnez opened a new pull request, #21015:
URL: https://github.com/apache/superset/pull/21015

   ### SUMMARY
   - When Bar chart is used as serie type, we need to hide values that are 
greater than the max Y Axis Bound so users don't get inconsistency problems 
with other serie types. User can still see the value using the tooltip.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   
![error](https://user-images.githubusercontent.com/38889534/183497972-1dea39dd-6a1f-4f20-8adf-3ada4a1267b9.gif)
   
   After:
   
![test](https://user-images.githubusercontent.com/38889534/183498096-158185a9-c5b6-433a-9d5d-4c1a6e37bed7.gif)
   <img width="1672" alt="tooltip_1" 
src="https://user-images.githubusercontent.com/38889534/183498226-64a706f4-101e-4bd8-abf4-e5e73863a366.png";>
   <img width="1672" alt="tooltip_2" 
src="https://user-images.githubusercontent.com/38889534/183498241-78928915-5a7a-4a65-a9a4-f0dcca005434.png";>
   
   
   ### TESTING INSTRUCTIONS
   1. Create a mixed time series chart
   2. Make sure value labels are on
   3. In your second query, set the Y-Axis Bound Maximum to lower than the 
initial value in the chart
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to