eschutho commented on code in PR #20903:
URL: https://github.com/apache/superset/pull/20903#discussion_r940746441
##########
superset/reports/commands/execute.py:
##########
@@ -342,23 +343,34 @@ def _get_notification_content(self) ->
NotificationContent:
):
embedded_data = self._get_embedded_data()
+ notification_source = None
+ notification_source_id = None
Review Comment:
nit, but can you declare these two at the beginning of the method with the
others? It read at first as if you were reassigning the values rather than
declaring and I had to check the top of the method to be sure which one it was.
##########
superset/utils/core.py:
##########
@@ -917,6 +918,9 @@ def send_email_smtp( # pylint:
disable=invalid-name,too-many-arguments,too-many
msg["Subject"] = subject
msg["From"] = smtp_mail_from
msg["To"] = ", ".join(smtp_mail_to)
+
+ api_object = {"metadata": log_data}
+ msg["X-MSYS-API"] = json.dumps(api_object)
Review Comment:
are you moving these two lines and the `_get_log_data` method to the config?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
