lyndsiWilliams opened a new pull request, #21020: URL: https://github.com/apache/superset/pull/21020
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This PR fixes the final test in `SaveDatasetModal.test.tsx`. Initially the test for the overwrite screen buttons had to be squashed into the previous test because creating another test after this test would always render incorrectly and fail. The problem was that some timers used by the component were being fired after the test is run. The solution was to use `jest.useFakeTimers()` at the top of the file, so that the timers run in the test environment. I also completed testing on the overwrite screen and cleaned up some arbitrary `act` wrappers. ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> - In your terminal, cd into `superset-frontend` - Run the command `npm run test superset-frontend/src/SqlLab/components/SaveDatasetModal/SaveDatasetModal.test.tsx` - Observe that all tests pass with no act errors ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
