michael-s-molina commented on PR #20995: URL: https://github.com/apache/superset/pull/20995#issuecomment-1209378883
Hi @reesercollins. Thank you for your contribution. I have some concerns with the current approach: The most important one is that when editing a tag, you don't have access to the other options. If `allowNewValue` is false, you shouldn’t be able to change the value to something that does not exist. There's also the problem of typing a value that has not been loaded from the server-side when using an async select, which can result in a missing id for example. Another problem is the input inside input pattern, which I don't think will be approved by the design team. Personally, I don't think the delete/retype requires much effort. If that was the case, Ant Design would support editing a tag natively. I'm not sure if the added code complexity pays off in this case. If you think this is really necessary we could start a discussion with the design team to see if there's an alternative way to edit the tags as long as we resolve the technical problems too. Let me know your thoughts and thanks again for the PR. I really appreciate CCCS's contributions regarding this component. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
