[GitHub] [superset] justinpark opened a new pull request, #21032: fix(plugin-echarts-timeseries): invalid total label location for negative values in stacked bar chart

[GitBox]

justinpark opened a new pull request, #21032:
URL: https://github.com/apache/superset/pull/21032

   ### SUMMARY
   A stacked chart sets the total value only, the total label displays on top 
of the most latest non-null data index item.
   When the data contains negative values, the stack chart places the item 
underneath the positive item.
   Therefore the total value can be located within the stack bar when a 
negative value in the most latest index.
   This commit fixes the `extractShowValueIndexes` logic by ignoring the 
negative values for onlyTotal option.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Before:
   
   <img width="497" alt="Screen Shot 2022-08-08 at 4 17 59 PM" 
src="https://user-images.githubusercontent.com/1392866/183726417-a9f5d47f-aa1b-43c8-bbe3-28df87ef04a3.png";>
   
   After:
   
   <img width="498" alt="Screen Shot 2022-08-08 at 4 18 14 PM" 
src="https://user-images.githubusercontent.com/1392866/183726412-cc23cf05-7af2-4305-8dd4-413f6ef24914.png";>
   
   
   ### TESTING INSTRUCTIONS
   
   Storybook
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org