villebro opened a new pull request, #21035: URL: https://github.com/apache/superset/pull/21035
### SUMMARY Add query cancellation functionality to Trino spec as outlined here: https://trino.io/docs/current/connector/system.html#system-connector-procedures. Since we're now extending the Presto spec which handles query cancellation implicitly, but the Trino driver doesn't, we also need to return `False` on `has_implicit_cancel`. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Previously, cancelling a query on Trino would leave the query running on the database. However, after this change, when cancelling a query, the query will terminate with the following error:  On the Trino UI we can see the following:  ### TESTING INSTRUCTIONS 1. Run a long running query on Trino 2. Cancel the query 3. Verify that the query terminates ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
