villebro commented on code in PR #21002:
URL: https://github.com/apache/superset/pull/21002#discussion_r942754943
##########
tests/unit_tests/pandas_postprocessing/test_contribution.py:
##########
@@ -74,7 +74,7 @@ def test_contribution():
rename_columns=["pct_a"],
)
assert processed_df.columns.tolist() == ["a", "b", "c", "pct_a"]
- assert_array_equal(processed_df["a"].tolist(), [1, 3, nan])
- assert_array_equal(processed_df["b"].tolist(), [1, 9, nan])
- assert_array_equal(processed_df["c"].tolist(), [nan, nan, nan])
+ assert_array_equal(processed_df["a"].tolist(), [1, 3, 0])
+ assert_array_equal(processed_df["b"].tolist(), [1, 9, 0])
+ assert_array_equal(processed_df["c"].tolist(), [0, 0, 0])
Review Comment:
@betodealmeida I agree completely, for this case it does make sense IMO. If
needed I can put aside some time this week for stepping through the
contribution code to see where the difference is happening so we can pinpoint
what's changed. I probably didn't say it here yet, but this is a great PR and
helps keep Superset up to date, so I really appreciate the work done here by
@EugeneTorap 🙂👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
