vin01 opened a new issue, #21041: URL: https://github.com/apache/superset/issues/21041
Hi, currently hostname validation (https://github.com/apache/superset/blob/master/superset/utils/network.py#L42) and port check (https://github.com/apache/superset/blob/master/superset/utils/network.py#L25) use only ipv4 addresses (because of `gethostbyname` and `AF_INET` respectively) This results in ipv6 only hostnames being marked as invalid and ports show up as closed. Both of these can be. fixed by using `getaddrinfo`. - https://docs.python.org/3/library/socket.html#socket.gethostbyname - https://docs.python.org/3/library/socket.html#socket.gethostbyname I am creating this single issue to track both these bugs as they are related. Hopefully that is alright with the [guidelines](https://github.com/apache/superset/blob/master/CONTRIBUTING.md#pull-request-guidelines) ;) Please review related patches. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
