[GitHub] [superset] justinpark opened a new pull request, #21044: fix(plugin-echarts-mixed-timeseries): missing value format

Wed, 10 Aug 2022 16:27:34 -0700 


justinpark opened a new pull request, #21044:
URL: https://github.com/apache/superset/pull/21044

   ### SUMMARY
   When we show  values for a mixed time series chart (stacked bar + line 
chart), the value format won't be reflected in the values shown in the chart.
   This commit updates mixed-timeseries' transformProps to include the missing 
formatter with dependent's attributes.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Before:
   
   <img width="498" alt="Screen Shot 2022-08-10 at 3 56 09 PM" 
src="https://user-images.githubusercontent.com/1392866/184039855-c45f54f2-8d92-4471-b6f7-127ad7ec8213.png";>
   
   After:
   
   <img width="497" alt="Screen Shot 2022-08-10 at 3 58 16 PM" 
src="https://user-images.githubusercontent.com/1392866/184039850-a34bb61d-fda5-49aa-bf6a-71bccda3f28b.png";>
   
   
   ### TESTING INSTRUCTIONS
   storybook
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to