zhaoyongjie commented on PR #20728: URL: https://github.com/apache/superset/pull/20728#issuecomment-1211526034
> > @codyml Thanks for the new feature, I have tested this feature in my local. there are 2 issues. > > > > 1. The drill detail modal always sends `force query`. the `force query` means that don't use data cache in the backend, so every force query will send actual SQL to the underlying database, usually, it's an "expensive" operation. > > > >  > > > > 2. The drill detail request is 2 times when I click` drill to detail`. > > > > drill.to.detail.mov > > @zhaoyongjie Thanks for looking it over again. I fixed (2), so it should only send one request. For (1), do you think we should have `force=false` for all of these requests? Should we be worried about getting stale data? I could also have it only do `force=true` if you click the reload button in the upper right of the modal. For the ideal, the `force` is sent when the `force refresh` is selected in three-dot menu. IMO, this can be optimized later, just keep `force=false` for all of requests.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
