zhaoyongjie commented on code in PR #21003:
URL: https://github.com/apache/superset/pull/21003#discussion_r943449016
##########
tests/integration_tests/core_tests.py:
##########
@@ -763,6 +763,52 @@ def test_extra_table_metadata(self):
f"/superset/extra_table_metadata/{example_db.id}/birth_names/{schema}/"
)
+ def test_required_params_in_sql_json(self):
+ self.login()
+ client_id = "{}".format(random.getrandbits(64))[:10]
+
+ data = {"client_id": client_id}
+ rv = self.client.post(
+ "/superset/sql_json/",
+ json=data,
+ )
+ failed_resp = {
+ "sql": ["Missing data for required field."],
+ "database_id": ["Missing data for required field."],
+ }
+ resp_data = json.loads(rv.data.decode("utf-8"))
+ self.assertDictEqual(resp_data, failed_resp)
+ self.assertEqual(rv.status_code, 400)
+
+ data = {"sql": "SELECT 1", "client_id": client_id}
+ rv = self.client.post(
+ "/superset/sql_json/",
+ json=data,
+ )
+ failed_resp = {"database_id": ["Missing data for required field."]}
+ resp_data = json.loads(rv.data.decode("utf-8"))
+ self.assertDictEqual(resp_data, failed_resp)
+ self.assertEqual(rv.status_code, 400)
+
+ data = {"database_id": 1, "client_id": client_id}
+ rv = self.client.post(
+ "/superset/sql_json/",
+ json=data,
+ )
+ failed_resp = {"sql": ["Missing data for required field."]}
+ resp_data = json.loads(rv.data.decode("utf-8"))
+ self.assertDictEqual(resp_data, failed_resp)
+ self.assertEqual(rv.status_code, 400)
Review Comment:
same before
##########
tests/integration_tests/core_tests.py:
##########
@@ -763,6 +763,52 @@ def test_extra_table_metadata(self):
f"/superset/extra_table_metadata/{example_db.id}/birth_names/{schema}/"
)
+ def test_required_params_in_sql_json(self):
+ self.login()
+ client_id = "{}".format(random.getrandbits(64))[:10]
+
+ data = {"client_id": client_id}
+ rv = self.client.post(
+ "/superset/sql_json/",
+ json=data,
+ )
+ failed_resp = {
+ "sql": ["Missing data for required field."],
+ "database_id": ["Missing data for required field."],
+ }
+ resp_data = json.loads(rv.data.decode("utf-8"))
+ self.assertDictEqual(resp_data, failed_resp)
+ self.assertEqual(rv.status_code, 400)
+
+ data = {"sql": "SELECT 1", "client_id": client_id}
+ rv = self.client.post(
+ "/superset/sql_json/",
+ json=data,
+ )
+ failed_resp = {"database_id": ["Missing data for required field."]}
+ resp_data = json.loads(rv.data.decode("utf-8"))
+ self.assertDictEqual(resp_data, failed_resp)
+ self.assertEqual(rv.status_code, 400)
+
+ data = {"database_id": 1, "client_id": client_id}
+ rv = self.client.post(
+ "/superset/sql_json/",
+ json=data,
+ )
+ failed_resp = {"sql": ["Missing data for required field."]}
+ resp_data = json.loads(rv.data.decode("utf-8"))
+ self.assertDictEqual(resp_data, failed_resp)
+ self.assertEqual(rv.status_code, 400)
+
+ data = {"sql": "SELECT 1", "database_id": 1, "client_id": client_id}
+ rv = self.client.post(
+ "/superset/sql_json/",
+ json=data,
+ )
+ resp_data = json.loads(rv.data.decode("utf-8"))
+ self.assertEqual(resp_data.get("status"), "success")
+ self.assertEqual(rv.status_code, 200)
Review Comment:
same before
##########
tests/integration_tests/core_tests.py:
##########
@@ -763,6 +763,52 @@ def test_extra_table_metadata(self):
f"/superset/extra_table_metadata/{example_db.id}/birth_names/{schema}/"
)
+ def test_required_params_in_sql_json(self):
+ self.login()
+ client_id = "{}".format(random.getrandbits(64))[:10]
+
+ data = {"client_id": client_id}
+ rv = self.client.post(
+ "/superset/sql_json/",
+ json=data,
+ )
+ failed_resp = {
+ "sql": ["Missing data for required field."],
+ "database_id": ["Missing data for required field."],
+ }
+ resp_data = json.loads(rv.data.decode("utf-8"))
+ self.assertDictEqual(resp_data, failed_resp)
+ self.assertEqual(rv.status_code, 400)
Review Comment:
no blocking, nits
```suggestion
assert rv.json == failed_resp
assert rv.status_code == 400
```
##########
tests/integration_tests/core_tests.py:
##########
@@ -763,6 +763,52 @@ def test_extra_table_metadata(self):
f"/superset/extra_table_metadata/{example_db.id}/birth_names/{schema}/"
)
+ def test_required_params_in_sql_json(self):
+ self.login()
+ client_id = "{}".format(random.getrandbits(64))[:10]
+
+ data = {"client_id": client_id}
+ rv = self.client.post(
+ "/superset/sql_json/",
+ json=data,
+ )
+ failed_resp = {
+ "sql": ["Missing data for required field."],
+ "database_id": ["Missing data for required field."],
+ }
+ resp_data = json.loads(rv.data.decode("utf-8"))
+ self.assertDictEqual(resp_data, failed_resp)
+ self.assertEqual(rv.status_code, 400)
+
+ data = {"sql": "SELECT 1", "client_id": client_id}
+ rv = self.client.post(
+ "/superset/sql_json/",
+ json=data,
+ )
+ failed_resp = {"database_id": ["Missing data for required field."]}
+ resp_data = json.loads(rv.data.decode("utf-8"))
+ self.assertDictEqual(resp_data, failed_resp)
+ self.assertEqual(rv.status_code, 400)
Review Comment:
same before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
