codyml commented on PR #20728: URL: https://github.com/apache/superset/pull/20728#issuecomment-1212293001
> Some more comments from manual testing: > > * When resizing the modal, the pagination should stick to the bottom. Also, there are 2 vertical scrolls there. I believe we should only have 1 vertical scroll > * Let's set a minimum size for the modal as the user should never resize it to the point that is unusable > * When refreshing, should we move the user to page 1? I am thinking of an edge case where we have 2 pages initially, but a bunch of data is deleted or the underlying dataset has changed, now you only have 1 page, but the request will still try to look for page 2 causing a scenario like the one depicted below > * In the example above you can also see some weird layout for the no results which needs improvement > * I think we can consider this problem for a next phase, but I believe the user should be able to select exclusively all the content of the table without selecting any other area of the application @geido Good call on the modal resizing and good catch on the extra scrollbars, will fix! Agreed on the reset to page 1 on refresh, will update. For the selection, maybe we should reintroduce the Copy button if it's clear that it'll only copy the one page? But sure, let's tackle separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
