lyndsiWilliams commented on code in PR #21058: URL: https://github.com/apache/superset/pull/21058#discussion_r944570630
########## superset-frontend/src/views/CRUD/data/dataset/DatasetPage/DatasetPage.test.tsx: ########## @@ -0,0 +1,42 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import React from 'react'; +import { render, screen } from 'spec/helpers/testing-library'; +import DatasetPage from 'src/views/CRUD/data/dataset/DatasetPage'; + +describe('DatasetPage', () => { Review Comment: - DatasetPage is the whole "add dataset" page - DatasetLayout structures all of the components on the page. - DatasetPanel is the center component currently holding the "Select Dataset Source" blank state I think if we were to rename them I'd suggest something like: - DatasetPage -> AddDatasetPage - Since there will also be an EditDatasetPage - DatasetLayout -> Either DatasetPageLayout or keep it as is, I think it describes it properly - DatasetPanel -> Could probably leave this name as is as well, but I'm open to suggestions 😁 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
