[GitHub] [superset] stevetracvc opened a new pull request, #21084: fix(native filters) groupby filter issue

Sun, 14 Aug 2022 10:00:55 -0700 


stevetracvc opened a new pull request, #21084:
URL: https://github.com/apache/superset/pull/21084

   ### SUMMARY
   There's an odd error when trying to use the groupby filter, resulting in 
"TypeError: Cannot read properties of undefined (reading 'length')"
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   broken:
   
![groupby_broken](https://user-images.githubusercontent.com/70416691/184547228-908bc7b1-855f-492e-89b5-6d0f6d22c0bb.png)
   <img width="813" alt="groupby_error_1" 
src="https://user-images.githubusercontent.com/70416691/184547239-167297fd-2b30-41d3-a7ae-6b389983d806.png";>
   
   works:
   
![groupby_works](https://user-images.githubusercontent.com/70416691/184547234-cf5c63a9-2ba3-4e39-957b-9261b0a07b8a.png)
   
   
   
   ### TESTING INSTRUCTIONS
   Create a new groupby filter on a dashboard and see how you get the black 
error boxes.
   
   Full error message:
   ```
   Oops! An error occurred!
   TypeError: Cannot read properties of undefined (reading 'length')
   Stack Trace:
   in PluginFilterGroupBy (created by CustomLoadableRenderer)
   in CustomLoadableRenderer (created by SuperChartCore)
   in div (created by SuperChartCore)
   in SuperChartCore (created by ParentSize)
   in ErrorBoundary (created by ParentSize)
   in div (created by ParentSize)
   in ParentSize (created by SuperChart)
   in div
   in Unknown (created by SuperChart)
   in SuperChart (created by WithTheme(SuperChart))
   in WithTheme(SuperChart) (created by FilterValue)
   in div (created by Styled(div))
   in Styled(div) (created by FilterValue)
   in FilterValue (created by FilterControl)
   in div (created by FormItemInput)
   in div (created by FormItemInput)
   in div (created by Col)
   in Col (created by FormItemInput)
   in FormItemInput (created by FormItem)
   in div (created by Row)
   in Row (created by FormItem)
   in FormItem (created by Styled(FormItem))
   in Styled(FormItem) (created by FilterControl)
   in div (created by Trigger)
   in Trigger (created by ForwardRef(Tooltip))
   in ForwardRef(Tooltip) (created by Tooltip)
   in Tooltip (created by Popover)
   in Popover (created by FilterCard)
   in FilterCard (created by FilterControl)
   in form (created by ForwardRef(Form))
   in ForwardRef(Form) (created by ForwardRef(InternalForm))
   in SizeContextProvider (created by ForwardRef(InternalForm))
   in ForwardRef(InternalForm) (created by Styled(Component))
   in Styled(Component) (created by Form)
   in Form (created by Styled(Form))
   in Styled(Form) (created by FilterControl)
   in FilterControl (created by FilterControls)
   in InPortal (created by FilterControls)
   in div (created by Styled(div))
   in Styled(div) (created by FilterControls)
   in FilterControls (created by FilterBar)
   in div (created by EmotionCssPropInternal)
   in EmotionCssPropInternal (created by FilterBar)
   in div (created by Styled(div))
   in Styled(div) (created by FilterBar)
   in div (created by Styled(div))
   in Styled(div) (created by FilterBar)
   in FilterBar (created by DashboardBuilder)
   in ErrorBoundary (created by DashboardBuilder)
   in div (created by Styled(div))
   in Styled(div) (created by DashboardBuilder)
   in div (created by Styled(div))
   in Styled(div) (created by DashboardBuilder)
   in div (created by Styled(div))
   in Styled(div) (created by DashboardBuilder)
   in DashboardBuilder (created by Dashboard)
   in Dashboard (created by ConnectFunction)
   in ConnectFunction (created by DashboardPage)
   in DashboardPage (created by DashboardRoute)
   in DashboardRoute (created by App)
   in ErrorBoundary (created by App)
   in Suspense (created by App)
   in Route (created by App)
   in Switch (created by App)
   in LocationProvider (created by Context.Consumer)
   in Route (created by QueryParamProvider)
   in QueryParamProvider (created by RootContextProviders)
   in DynamicPluginProvider (created by RootContextProviders)
   in EmbeddedUiConfigProvider (created by RootContextProviders)
   in FlashProvider (created by RootContextProviders)
   in Unknown (created by RootContextProviders)
   in Provider (created by RootContextProviders)
   in ThemeProvider (created by RootContextProviders)
   in RootContextProviders (created by App)
   in Router (created by BrowserRouter)
   in BrowserRouter (created by App)
   in App
   ```
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to