villebro commented on code in PR #21002:
URL: https://github.com/apache/superset/pull/21002#discussion_r945602901
##########
tests/unit_tests/pandas_postprocessing/test_contribution.py:
##########
@@ -74,7 +74,7 @@ def test_contribution():
rename_columns=["pct_a"],
)
assert processed_df.columns.tolist() == ["a", "b", "c", "pct_a"]
- assert_array_equal(processed_df["a"].tolist(), [1, 3, nan])
- assert_array_equal(processed_df["b"].tolist(), [1, 9, nan])
- assert_array_equal(processed_df["c"].tolist(), [nan, nan, nan])
+ assert_array_equal(processed_df["a"].tolist(), [1, 3, 0])
+ assert_array_equal(processed_df["b"].tolist(), [1, 9, 0])
+ assert_array_equal(processed_df["c"].tolist(), [0, 0, 0])
Review Comment:
@ghrom Python 3.10 is not currently officially supported by Superset; please
refer to the currently supported versions:
https://github.com/apache/superset/blob/394d62ee51b6feb6e23c2b24505ee469460db146/setup.py#L183-L186
The project is happy to help add support for Python 3.10, but we simply
can't merge this PR before ensuring that the regressions that it introduces
have been fixed. Again, I'm very happy that this test exists, as otherwise we
probably would have already merged this PR, introducing a regression.
In the meantime, use a supported version of Python when running Superset
(`pyenv` and `virtualenv` are great tools for this).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
