reesercollins commented on code in PR #21064:
URL: https://github.com/apache/superset/pull/21064#discussion_r945949777
##########
superset-frontend/plugins/plugin-chart-table/src/DataTable/hooks/useSticky.tsx:
##########
@@ -246,23 +246,6 @@ function StickyWrap({
</colgroup>
);
- // header columns do not have vertical scroll bars,
- // so we add scroll bar size to the last column
- const headerColgroup =
- sticky.hasVerticalScroll && scrollBarSize ? (
- <colgroup>
- {colWidths.map((x, i) => (
- // eslint-disable-next-line react/no-array-index-key
- <col
- key={i}
- width={x + (i === colWidths.length - 1 ? scrollBarSize : 0)}
Review Comment:
I haven't been able to find any instances where this removal causes any
breaking changes, however, I am not the most knowledgeable when it comes to the
usage of this plugin within superset since our organization uses a custom table
viz.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
