reesercollins commented on code in PR #20312:
URL: https://github.com/apache/superset/pull/20312#discussion_r947992255
##########
superset/datasets/api.py:
##########
@@ -769,9 +775,15 @@ def import_(self) -> Response:
else None
)
overwrite = request.form.get("overwrite") == "true"
+ sync_columns = request.form.get("sync_columns") == "true"
+ sync_metrics = request.form.get("sync_metrics") == "true"
command = ImportDatasetsCommand(
- contents, passwords=passwords, overwrite=overwrite
+ contents,
+ passwords=passwords,
+ overwrite=overwrite,
+ sync_columns=sync_columns,
+ sync_metrics=sync_metrics,
Review Comment:
`sync_columns` and `sync_metrics` means the import command will remove
columns and metrics which don't appear in the dataset YAML.
https://github.com/apache/superset/blob/76d6a9af91a71401d158bc150518b3c9366030ac/superset/datasets/commands/importers/v0.py#L249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
