diegomedina248 commented on PR #20910: URL: https://github.com/apache/superset/pull/20910#issuecomment-1222261111
> I found some issues in this PR: 1, if user click on the filter indicator when chart is in fullscreen view, user will bring out to the normal view and the 3 dot menu on charts are not open. I test on superset master it seems like on master click on the filter indicator in enlarge chart view did not bring user to fullscreen view. > > Screen.Recording.2022-08-18.at.11.06.53.AM.mov > 2, for numerical filter, it looks like the filter bar is not shown correctly when user select filter range: <img alt="Screen Shot 2022-08-18 at 11 13 27 AM" width="1792" src="https://user-images.githubusercontent.com/81597121/185465549-4974da3a-76de-4b9b-b50b-e8beba111d08.png";> mm, I actually couldn't reproduce those. I did rebase from master, to have the branch up to date, and couldn't reproduce either that way. Here's what I'm doing: https://user-images.githubusercontent.com/17252075/185916954-9f0699d2-6808-4773-823d-2188fdfa801f.mov -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/81597121/185465549-4974da3a-76de-4b9b-b50b-e8beba111d08.png"](https://user-images.githubusercontent.com/81597121/185465549-4974da3a-76de-4b9b-b50b-e8beba111d08.png"){kind=link}